Skip to content

add benchmarks for timestamp parsing #18698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2017

Conversation

jbrockmendel
Copy link
Member

There's a reasonable case to be made that these and timeseries.ToDatetime benchmarks belong in the same place. LMK if there's a preference.

Small flake8 fixups got timedelta.py passing, enabled linting for modules starting with "t".

@codecov
Copy link

codecov bot commented Dec 8, 2017

Codecov Report

Merging #18698 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18698      +/-   ##
==========================================
- Coverage    91.6%   91.56%   -0.05%     
==========================================
  Files         153      153              
  Lines       51272    51272              
==========================================
- Hits        46967    46946      -21     
- Misses       4305     4326      +21
Flag Coverage Δ
#multiple 89.42% <ø> (-0.03%) ⬇️
#single 40.68% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 64.78% <0%> (-1.74%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288bf6e...75e5cc3. Read the comment docs.

@jreback jreback added the Benchmark Performance (ASV) benchmarks label Dec 9, 2017
@jreback jreback added this to the 0.22.0 milestone Dec 9, 2017
@jreback jreback merged commit e658148 into pandas-dev:master Dec 9, 2017
@jreback
Copy link
Contributor

jreback commented Dec 9, 2017

thanks!

@jbrockmendel jbrockmendel deleted the time_parsing branch January 23, 2018 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants